Avoiding a couple warnings

This commit is contained in:
Pierre Pronchery 2011-05-04 19:23:57 +00:00
parent 5d301f201f
commit ecfc1901b0
5 changed files with 31 additions and 22 deletions

View File

@ -7,7 +7,7 @@ msgid ""
msgstr ""
"Project-Id-Version: Browser 0.1.4\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2011-05-04 20:57+0200\n"
"POT-Creation-Date: 2011-05-04 21:23+0200\n"
"PO-Revision-Date: 2010-03-29 23:28+0200\n"
"Last-Translator: Pierre Pronchery <khorben@defora.org>\n"
"Language-Team: English\n"
@ -355,11 +355,11 @@ msgstr ""
msgid " to \""
msgstr ""
#: ../src/common.c:139
#: ../src/common.c:148
msgid "New symbolic link"
msgstr ""
#: ../src/common.c:149
#: ../src/common.c:158
msgid "Destination: "
msgstr ""

View File

@ -7,7 +7,7 @@ msgid ""
msgstr ""
"Project-Id-Version: Browser 0.1.4\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2011-05-04 20:57+0200\n"
"POT-Creation-Date: 2011-05-04 21:23+0200\n"
"PO-Revision-Date: 2010-03-30 01:04+0200\n"
"Last-Translator: Pierre Pronchery <khorben@defora.org>\n"
"Language-Team: Spanish\n"
@ -355,11 +355,11 @@ msgstr ""
msgid " to \""
msgstr ""
#: ../src/common.c:139
#: ../src/common.c:148
msgid "New symbolic link"
msgstr ""
#: ../src/common.c:149
#: ../src/common.c:158
msgid "Destination: "
msgstr ""

View File

@ -7,7 +7,7 @@ msgid ""
msgstr ""
"Project-Id-Version: Browser 0.1.4\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2011-05-04 20:57+0200\n"
"POT-Creation-Date: 2011-05-04 21:23+0200\n"
"PO-Revision-Date: 2010-03-29 23:28+0200\n"
"Last-Translator: Pierre Pronchery <khorben@defora.org>\n"
"Language-Team: French\n"
@ -355,11 +355,11 @@ msgstr "déplacement en cours"
msgid " to \""
msgstr " vers \""
#: ../src/common.c:139
#: ../src/common.c:148
msgid "New symbolic link"
msgstr "Nouveau lien symbolique"
#: ../src/common.c:149
#: ../src/common.c:158
msgid "Destination: "
msgstr "Destination: "

View File

@ -7,7 +7,7 @@ msgid ""
msgstr ""
"Project-Id-Version: Browser 0.1.4\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2011-05-04 20:57+0200\n"
"POT-Creation-Date: 2011-05-04 21:23+0200\n"
"PO-Revision-Date: 2010-04-07 23:18+0200\n"
"Last-Translator: Pierre Pronchery <khorben@defora.org>\n"
"Language-Team: Italian\n"
@ -355,11 +355,11 @@ msgstr ""
msgid " to \""
msgstr ""
#: ../src/common.c:139
#: ../src/common.c:148
msgid "New symbolic link"
msgstr ""
#: ../src/common.c:149
#: ../src/common.c:158
msgid "Destination: "
msgstr ""

View File

@ -80,10 +80,11 @@ static int _common_drag_data_received(GdkDragContext * context,
/* common_exec */
static int _common_exec(char const * program, char const * flags, GList * args)
{
unsigned long i = flags != NULL ? 3 : 2;
char const ** argv = NULL;
int ret = 0;
unsigned long i = (flags != NULL) ? 3 : 2;
char ** argv = NULL;
GList * a;
char const ** p;
char ** p;
GError * error = NULL;
if(args == NULL)
@ -105,19 +106,27 @@ static int _common_exec(char const * program, char const * flags, GList * args)
if(argv == NULL)
return 0;
#ifdef DEBUG
argv[0] = "echo";
argv[0] = strdup("echo");
#else
argv[0] = program;
argv[0] = strdup(program);
#endif
if(argv[0] == NULL)
{
free(argv);
return -error_set_code(1, "%s: %s", program, strerror(errno));
}
argv[i] = NULL;
i = 1;
i = 0;
if(flags != NULL)
argv[i++] = flags;
argv[i] = "--";
argv[++i] = strdup(flags); /* XXX may fail too */
argv[i + 1] = "--";
if(g_spawn_async(NULL, argv, NULL, G_SPAWN_SEARCH_PATH, NULL, NULL,
NULL, &error) != TRUE)
return -error_set_code(1, "%s", error->message);
return 0;
ret = error_set_code(1, "%s", error->message);
free(argv[0]);
if(flags != NULL)
free(argv[i]);
return ret;
}
#endif /* COMMON_EXEC */