From 4046248133fd72a43f6e9b501d5908d345116659 Mon Sep 17 00:00:00 2001 From: Pierre Pronchery Date: Mon, 29 Jul 2024 19:33:12 +0200 Subject: [PATCH] camera: fix possible off-by-one with strncat() --- src/camera.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/camera.c b/src/camera.c index 44c289a..e103c69 100644 --- a/src/camera.c +++ b/src/camera.c @@ -932,9 +932,9 @@ static void _properties_window(Camera * camera) for(i = 0; capabilities[i].name != NULL; i++) if(camera->cap.capabilities & capabilities[i].capability) { - strncat(buf, sep, sizeof(buf) - strlen(buf)); + strncat(buf, sep, sizeof(buf) - strlen(buf) - 1); strncat(buf, capabilities[i].name, sizeof(buf) - - strlen(buf)); + - strlen(buf) - 1); sep = ", "; } buf[sizeof(buf) - 1] = '\0';