Found potential issues when calling

This commit is contained in:
Pierre Pronchery 2010-05-27 15:25:58 +00:00
parent e12b62eb11
commit 323fa29bd8
2 changed files with 5 additions and 3 deletions

View File

@ -828,7 +828,7 @@ static int _is_number(char const * number)
}
/* modem_call_queue */
/* modem_call_do */
static int _modem_call_do(GSM * gsm, char const * command)
{
GSMCommand * gsmc;
@ -837,8 +837,8 @@ static int _modem_call_do(GSM * gsm, char const * command)
return 1;
gsm_command_set_priority(gsmc, GSM_PRIORITY_HIGH);
gsm_command_set_error(gsmc, GSM_ERROR_CALL_FAILED);
gsm_command_set_callback(gsmc, NULL);
gsm_command_set_timeout(gsmc, 30000);
gsm_command_set_callback(gsmc, NULL); /* XXX check if active? */
gsm_command_set_timeout(gsmc, 30000); /* XXX is it really necessary? */
if(gsm_queue_command(gsm, gsmc) == 0)
return 0;
gsm_command_delete(gsmc);

View File

@ -838,6 +838,7 @@ void phone_messages_call_selected(Phone * phone)
if(number == NULL)
return;
gsm_call(phone->gsm, GSM_CALL_TYPE_VOICE, number);
phone_show_call(phone, TRUE, PHONE_CALL_OUTGOING, " ", number);
g_free(number);
}
@ -903,6 +904,7 @@ void phone_read_call(Phone * phone)
if((number = gtk_label_get_text(GTK_LABEL(phone->re_number))) == NULL)
return;
gsm_call(phone->gsm, GSM_CALL_TYPE_VOICE, number);
phone_show_call(phone, TRUE, PHONE_CALL_OUTGOING, " ", number);
}