From bc176452d7d426ad2aac1077d4986ba5ff10000f Mon Sep 17 00:00:00 2001 From: Pierre Pronchery Date: Tue, 6 Apr 2021 03:02:02 +0200 Subject: [PATCH] No longer ignore errors when commands are not found Now that tests can easily be made optional, they should really be deterministic, and fail when they cannot really be performed. --- src/scripts/tests/clint.sh | 4 ---- src/scripts/tests/fixme.sh | 4 ---- src/scripts/tests/htmllint.sh | 4 ---- src/scripts/tests/phplint.sh | 4 ---- src/scripts/tests/pylint.sh | 4 ---- src/scripts/tests/shlint.sh | 4 ---- src/scripts/tests/xmllint.sh | 4 ---- 7 files changed, 28 deletions(-) diff --git a/src/scripts/tests/clint.sh b/src/scripts/tests/clint.sh index a7d22ba..f27d49b 100755 --- a/src/scripts/tests/clint.sh +++ b/src/scripts/tests/clint.sh @@ -118,10 +118,6 @@ _debug() { echo "$@" 1>&3 "$@" - res=$? - #ignore errors when the command is not available - [ $res -eq 127 ] && return 0 - return $res } diff --git a/src/scripts/tests/fixme.sh b/src/scripts/tests/fixme.sh index 84319cf..516297b 100755 --- a/src/scripts/tests/fixme.sh +++ b/src/scripts/tests/fixme.sh @@ -199,10 +199,6 @@ _debug() { echo "$@" 1>&3 "$@" - res=$? - #ignore errors when the command is not available - [ $res -eq 127 ] && return 0 - return $res } diff --git a/src/scripts/tests/htmllint.sh b/src/scripts/tests/htmllint.sh index 37975c3..0f930f5 100755 --- a/src/scripts/tests/htmllint.sh +++ b/src/scripts/tests/htmllint.sh @@ -81,10 +81,6 @@ _debug() { echo "$@" 1>&3 "$@" - res=$? - #ignore errors when the command is not available - [ $res -eq 127 ] && return 0 - return $res } diff --git a/src/scripts/tests/phplint.sh b/src/scripts/tests/phplint.sh index 1b53a1b..5bde1b6 100755 --- a/src/scripts/tests/phplint.sh +++ b/src/scripts/tests/phplint.sh @@ -84,10 +84,6 @@ _debug() { echo "$@" 1>&3 "$@" - res=$? - #ignore errors when the command is not available - [ $res -eq 127 ] && return 0 - return $res } diff --git a/src/scripts/tests/pylint.sh b/src/scripts/tests/pylint.sh index 7c50cfd..30a50c8 100755 --- a/src/scripts/tests/pylint.sh +++ b/src/scripts/tests/pylint.sh @@ -86,10 +86,6 @@ _debug() { echo "$@" 1>&3 "$@" - res=$? - #ignore errors when the command is not available - [ $res -eq 127 ] && return 0 - return $res } diff --git a/src/scripts/tests/shlint.sh b/src/scripts/tests/shlint.sh index 586d237..a5d01a2 100755 --- a/src/scripts/tests/shlint.sh +++ b/src/scripts/tests/shlint.sh @@ -107,10 +107,6 @@ _debug() { echo "$@" 1>&3 "$@" - res=$? - #ignore errors when the command is not available - [ $res -eq 127 ] && return 0 - return $res } diff --git a/src/scripts/tests/xmllint.sh b/src/scripts/tests/xmllint.sh index 9e21aaf..410d797 100755 --- a/src/scripts/tests/xmllint.sh +++ b/src/scripts/tests/xmllint.sh @@ -86,10 +86,6 @@ _debug() { echo "$@" 1>&3 "$@" - res=$? - #ignore errors when the command is not available - [ $res -eq 127 ] && return 0 - return $res }