From f5151f322a0e731e1f96cebf8beb88cbe9e0b468 Mon Sep 17 00:00:00 2001
From: Pierre Pronchery <khorben@defora.org>
Date: Thu, 28 Mar 2019 15:31:34 +0100
Subject: [PATCH] Run callbacks in a subshell to protect variables

---
 doc/scripts/fixme.sh | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/doc/scripts/fixme.sh b/doc/scripts/fixme.sh
index a6d216f..3446aaf 100755
--- a/doc/scripts/fixme.sh
+++ b/doc/scripts/fixme.sh
@@ -74,7 +74,7 @@ _fixme()
 					;;
 			esac
 			[ -n "$callback" ] || continue
-			$callback "$filename" 2>&1
+			($callback "$filename") 2>&1
 			if [ $? -ne 0 ]; then
 				echo "$PROGNAME: $filename: FAIL" 1>&2
 				ret=2
@@ -86,31 +86,31 @@ _fixme()
 
 _fixme_asm()
 {
-	retc=0
+	ret=0
 	filename="$1"
 
 	#warnings
 	$GREP -nH '/\*.*\(TODO\|XXX\)' "$filename"
 	#failures
-	$GREP -nH '/\*.*FIXME' "$filename" && retc=2
-	return $retc
+	$GREP -nH '/\*.*FIXME' "$filename" && ret=2
+	return $ret
 }
 
 _fixme_c()
 {
-	retc=0
+	ret=0
 	filename="$1"
 
 	#warnings
 	$GREP -nH '/\(/\|\*\).*\(TODO\|XXX\)' "$filename"
 	#failures
-	$GREP -nH '/\(/\|\*\).*FIXME' "$filename" && retc=2
-	return $retc
+	$GREP -nH '/\(/\|\*\).*FIXME' "$filename" && ret=2
+	return $ret
 }
 
 _fixme_sh()
 {
-	retsh=0
+	ret=0
 	filename="$1"
 	#XXX avoid matching the regexp
 	comment="#"
@@ -118,8 +118,8 @@ _fixme_sh()
 	#warnings
 	$GREP -nH "$comment.*\\(TODO\\|XXX\\)" "$filename"
 	#failures
-	$GREP -nH "$comment.*FIXME" "$filename" && retsh=2
-	return $retsh
+	$GREP -nH "$comment.*FIXME" "$filename" && ret=2
+	return $ret
 }