DeforaOS/libSystem
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a memory leak

Browse Source 
It was unfortunately re-introduced from the Config class, when
correcting the key management for the Mutator class.
This commit is contained in:
Pierre Pronchery 2015-10-15 01:25:44 +02:00
parent cf9d44c326
commit a25f1598de
1 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/mutator.c
View File

@ -66,19 +66,24 @@ int mutator_set(Mutator * mutator, String const * key, void * value)
String * k; String * k;
String * oldk; String * oldk;
if(value == NULL) /* look for the former key */
if((oldk = hash_get_key(mutator, key)) == NULL)
{ {
/* look for the former key */ if(value == NULL)
if((oldk = hash_get_key(mutator, key)) == NULL)
/* there is nothing to do */ /* there is nothing to do */
return 0; return 0;
/* allocate the new key */
if((k = string_new(key)) == NULL)
return -1;
key = k;
} }
else else
oldk = NULL; {
/* allocate the key */ if(value != NULL)
if((k = string_new(key)) == NULL) oldk = NULL;
return -1; k = NULL;
if((ret = hash_set(mutator, k, value)) != 0) }
if((ret = hash_set(mutator, key, value)) != 0)
{ {
error_set("%s: %s", key, "Could not set the value"); error_set("%s: %s", key, "Could not set the value");
string_delete(k); string_delete(k);