Code cleanup

This commit is contained in:
Pierre Pronchery 2008-04-17 17:34:57 +00:00
parent cae65dec73
commit e99fa5c400
2 changed files with 4 additions and 3 deletions

View File

@ -13,6 +13,8 @@
* You should have received a copy of the Creative Commons Attribution- * You should have received a copy of the Creative Commons Attribution-
* NonCommercial-ShareAlike 3.0 along with libSystem; if not, browse to * NonCommercial-ShareAlike 3.0 along with libSystem; if not, browse to
* http://creativecommons.org/licenses/by-nc-sa/3.0/ */ * http://creativecommons.org/licenses/by-nc-sa/3.0/ */
/* FIXME:
* - integer overflows when resizing array */

View File

@ -43,9 +43,8 @@ Buffer * buffer_new(size_t size, char const * data)
if((buffer = object_new(sizeof(*buffer))) == NULL) if((buffer = object_new(sizeof(*buffer))) == NULL)
return NULL; return NULL;
if((buffer->data = malloc(size * sizeof(char))) == NULL) if((buffer->data = object_new(size)) == NULL)
{ {
error_set_code(1, "%s", strerror(errno));
object_delete(buffer); object_delete(buffer);
return NULL; return NULL;
} }
@ -61,7 +60,7 @@ Buffer * buffer_new(size_t size, char const * data)
/* buffer_delete */ /* buffer_delete */
void buffer_delete(Buffer * buffer) void buffer_delete(Buffer * buffer)
{ {
free(buffer->data); object_delete(buffer->data);
object_delete(buffer); object_delete(buffer);
} }