From a0b96b656eff6039cf460fd1623bf3778badec48 Mon Sep 17 00:00:00 2001
From: Pierre Pronchery <khorben@defora.org>
Date: Mon, 3 Oct 2016 23:44:35 +0200
Subject: [PATCH] Test the shell scripts for sanity

---
 project.conf       |   2 +-
 tests/project.conf |   7 +++
 tests/shlint.sh    | 122 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 130 insertions(+), 1 deletion(-)
 create mode 100644 tests/project.conf
 create mode 100755 tests/shlint.sh

diff --git a/project.conf b/project.conf
index 56c7307..406a20f 100644
--- a/project.conf
+++ b/project.conf
@@ -1,5 +1,5 @@
 package=scripts
 version=0.0.0
 
-subdirs=src,targets
+subdirs=src,targets,tests
 dist=Makefile,COPYING
diff --git a/tests/project.conf b/tests/project.conf
new file mode 100644
index 0000000..9da8765
--- /dev/null
+++ b/tests/project.conf
@@ -0,0 +1,7 @@
+targets=shlint.log
+dist=Makefile,shlint.sh
+
+[shlint.log]
+type=script
+script=./shlint.sh
+depends=shlint.sh
diff --git a/tests/shlint.sh b/tests/shlint.sh
new file mode 100755
index 0000000..ee5fafd
--- /dev/null
+++ b/tests/shlint.sh
@@ -0,0 +1,122 @@
+#!/bin/sh
+#$Id$
+#Copyright (c) 2014-2016 Pierre Pronchery <khorben@defora.org>
+#
+#Redistribution and use in source and binary forms, with or without
+#modification, are permitted provided that the following conditions are met:
+#
+# * Redistributions of source code must retain the above copyright notice, this
+#   list of conditions and the following disclaimer.
+# * Redistributions in binary form must reproduce the above copyright notice,
+#   this list of conditions and the following disclaimer in the documentation
+#   and/or other materials provided with the distribution.
+#
+#THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+#AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+#IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+#DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+#FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+#DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+#SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+#CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+#OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+#OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+
+
+#variables
+PROGNAME="shlint.sh"
+PROJECTCONF="../project.conf"
+#executables
+DATE="date"
+DEBUG="_debug"
+FIND="find"
+SHLINT="sh -n"
+SORT="sort -n"
+TR="tr"
+
+
+#functions
+#shlint
+_shlint()
+{
+	ret=0
+	subdirs="data doc src tests tools"
+
+	$DATE
+	echo
+	while read line; do
+		case "$line" in
+			"["*)
+				break
+				;;
+			"subdirs="*)
+				subdirs=${line#subdirs=}
+				subdirs=$(echo "$subdirs" | $TR ',' ' ')
+				;;
+		esac
+	done < "$PROJECTCONF"
+	for subdir in $subdirs; do
+		[ -d "../$subdir" ] || continue
+		for filename in $($FIND "../$subdir" -name '*.sh' | $SORT); do
+			$DEBUG $SHLINT "$filename" 2>&1
+			if [ $? -eq 0 ]; then
+				echo "$filename:"
+			else
+				echo "$PROGNAME: $filename: FAIL" 1>&2
+				ret=2
+			fi
+		done
+	done
+	return $ret
+}
+
+
+#debug
+_debug()
+{
+	echo "$@" 1>&3
+	"$@"
+	res=$?
+	#ignore errors when the command is not available
+	[ $res -eq 127 ]					&& return 0
+	return $res
+}
+
+
+#usage
+_usage()
+{
+	echo "Usage: $PROGNAME [-c] target" 1>&2
+	return 1
+}
+
+
+#main
+clean=0
+while getopts "cP:" name; do
+	case "$name" in
+		c)
+			clean=1
+			;;
+		P)
+			#XXX ignored for compatibility
+			;;
+		?)
+			_usage
+			exit $?
+			;;
+	esac
+done
+shift $((OPTIND - 1))
+if [ $# -ne 1 ]; then
+	_usage
+	exit $?
+fi
+target="$1"
+
+#clean
+[ $clean -ne 0 ] && exit 0
+
+exec 3>&1
+_shlint > "$target"