DeforaOS/utils
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ps: detect errors when generating pathnames

Browse Source
This commit is contained in:
Pierre Pronchery 2020-12-08 14:16:22 +01:00
parent 21c0d11c14
commit e4a3a93b1e
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/ps.c
View File

@ -87,9 +87,10 @@ static int _ps(Prefs * prefs)
continue; continue;
if(gr != NULL && st.st_gid != gr->gr_gid) if(gr != NULL && st.st_gid != gr->gr_gid)
continue; continue;
snprintf(buf, sizeof(buf), "%s/%s/%s", proc, de->d_name, if(snprintf(buf, sizeof(buf), "%s/%s/%s", proc, de->d_name,
"cmdline"); "cmdline") >= (int)sizeof(buf))
if((fp = fopen(buf, "r")) != NULL) buf[0] = '\0';
else if((fp = fopen(buf, "r")) != NULL)
{ {
s = fread(buf, sizeof(*buf), sizeof(buf) - 1, fp); s = fread(buf, sizeof(*buf), sizeof(buf) - 1, fp);
fclose(fp); fclose(fp);
@ -97,7 +98,8 @@ static int _ps(Prefs * prefs)
} }
else else
buf[0] = '\0'; buf[0] = '\0';
printf("%5lu %5lu %s\n", pid, (unsigned long)st.st_uid, buf); printf("%5lu %5lu%s%s\n", pid, (unsigned long)st.st_uid,
(buf[0] != '\0') ? " " : "", buf);
} }
closedir(dir); closedir(dir);
return 0; return 0;